Make the "Write Dump" layout tab based - #276
Open
jpglmart wants to merge 1 commit into
Open
Conversation
Owner
|
Thank you very much! This is a nice contribution! As soon as I will find some time to work on MCT again, I will look into it (might not be before winter holidays). |
Owner
|
I finally had some time to look into this. The code is great! But there are two visual things I'm not sure about. They are not your "fault", but they bother me...
I'm not sure what can be done to improve the experience and make all functions visible. Or if the layout should just stay the "shitty old way" ;) |
Goooler
reviewed
May 12, 2022
|
|
||
| dependencies { | ||
| implementation 'androidx.legacy:legacy-support-core-utils:1.0.0' | ||
| implementation 'com.android.support:design:28.0.0' |
Contributor
There was a problem hiding this comment.
You should use AndroidX dep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hi ikarus23,
As a regular user of MifareClassicTool, I would like to thank all of your work and effort in this project. I tried to add #36 as accurately as I could, but let me give you a brief description of this pull request contents:
Activities
BasicFragmentActivity is a FragmentActivity which implements NFC related bussines logic (same logic that is implemented on BasicActivity activity) by overriding onResume(), onPause() and onNewIntent(Intent intent) methods.
WriteTagFragmentActivity, which extends from BasicFragmentActivity, implements data writing related bussines logic (same logic that is implemented on WriteTag activity) and it also manages all four new fragments, displaying them on their respective tab and implementing their interfaces.
Fragments
There are four new fragments:
Each of these fragments handle user interaction with UI and use interfaces to communicate with managing activity (WriteTagFragmentActivity).
Layouts
There are five new layouts:
First layout includes all views displayed on WriteTagFragmentActivity and the rest of them include views displayed on fragments.
Dependencies
A new dependency (com.android.support:design:28.0.0) was added in order to include tabs.
Even WriteTag activity is not being used in this version, it was not deleted so it can be used as a reference. Please let me know about bugs you detect in this version. Thank you.