Skip to content

Add an option to copy all the sectors - #546

Merged
ikarus23 merged 4 commits into
ikarus23:masterfrom
Real96:copy_all_sectors
Jun 21, 2026
Merged

Add an option to copy all the sectors#546
ikarus23 merged 4 commits into
ikarus23:masterfrom
Real96:copy_all_sectors

Conversation

@Real96

@Real96 Real96 commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Add what was asked in #544

Comment thread Mifare Classic Tool/app/src/main/res/values/strings.xml Outdated
@ikarus23

Copy link
Copy Markdown
Owner

Looks good.

  1. Could you add a "to clipboard" in the strings? So "Copy all sectors to clipboard". I feel like this could add some context.
  2. Maybe all these somewhat similar functions should be next to each other. Could you move "Share", "Copy all sectors to clipboard" and "Export Dump" at the very end of the menu (in that order)? Thanks.

@Real96
Real96 force-pushed the copy_all_sectors branch from 9f6a89a to 2ec1574 Compare June 21, 2026 14:08
@Real96

Real96 commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the code review! All requested changes done! Let me know if you want me to change something else

@ikarus23

Copy link
Copy Markdown
Owner

Thanks! Looks good!

@ikarus23
ikarus23 merged commit fef7249 into ikarus23:master Jun 21, 2026
1 check passed
@Real96
Real96 deleted the copy_all_sectors branch June 21, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants