feat: victory screen, keepside and winname; fix#3012
Merged
Conversation
github-actions
Bot
added
PR: feat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feat:
keepside.enabled: If set to 1, characters keep their original match sides on the victory screen (P1 stays on the left, P2 stays on the right, even if P2 wins).winname: Accepts all standard text parameters. If defined, it displays only the winner’s name, regardless of team side or player number.With these new parameters, it’s now possible to recreate SF-style victory screens where the winner’s and loser’s portraits do not swap sides, and optionally show only the winner’s name.
Fix:
p2.num = 1to work even when using only a single portrait