Skip to content

feature/finished/IIA-2449: Allow User to Cancel "Add STAMP Version" Session AND IIA-2450 AND IIA-2451 AND IIA-2530#614

Merged
dukke merged 23 commits into
ikmdev:mainfrom
dukke:feature/finished/IIA-2449-STAMP-cancel
Aug 6, 2025
Merged

feature/finished/IIA-2449: Allow User to Cancel "Add STAMP Version" Session AND IIA-2450 AND IIA-2451 AND IIA-2530#614
dukke merged 23 commits into
ikmdev:mainfrom
dukke:feature/finished/IIA-2449-STAMP-cancel

Conversation

@dukke

@dukke dukke commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

@dukke dukke changed the title feature/finished/IIA-2449: Allow User to Cancel "Add STAMP Version" Session feature/finished/IIA-2449: Allow User to Cancel "Add STAMP Version" Session AND IIA-2450 AND IIA-2451 Aug 1, 2025
@dukke dukke changed the title feature/finished/IIA-2449: Allow User to Cancel "Add STAMP Version" Session AND IIA-2450 AND IIA-2451 feature/finished/IIA-2449: Allow User to Cancel "Add STAMP Version" Session AND IIA-2450 AND IIA-2451 AND IIA-2530 Aug 4, 2025
Comment thread kview/src/main/java/dev/ikm/komet/kview/mvvm/viewmodel/StampViewModel2.java Outdated
Comment thread kview/src/main/java/dev/ikm/komet/kview/mvvm/viewmodel/StampViewModel2.java Outdated
@carldea

carldea commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

I have had to fix a bug in cognitive library. Now the combobox value properties work correctly when calling the view model .reset() and .save(). Issue added and closed : carldea/cognitive#17

Seems to work. But I do see a minor issue with selection model have two selected items (doesn't affect anything). This could be a JavaFX bug.

@dukke

dukke commented Aug 6, 2025

Copy link
Copy Markdown
Contributor Author

@carldea added the code to save to the DB (fixing IIA-2446). The stamp feature is now complete.
Thanks!

@carldea carldea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Maybe in another ticket we can during EDIT mode we hide the ... popup button.

@dukke dukke merged commit 105014b into ikmdev:main Aug 6, 2025
7 checks passed
@dukke dukke deleted the feature/finished/IIA-2449-STAMP-cancel branch August 17, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants