Skip to content

[WIP] Add deferred features from fre.cmor for future implementation#31

Closed
Claude wants to merge 3 commits intomainfrom
claude/add-deferred-features-from-fre-cmor
Closed

[WIP] Add deferred features from fre.cmor for future implementation#31
Claude wants to merge 3 commits intomainfrom
claude/add-deferred-features-from-fre-cmor

Conversation

@Claude
Copy link
Copy Markdown
Contributor

@Claude Claude AI commented Apr 14, 2026

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.


This section details on the original issue you should resolve

<issue_title>Deferred Features from fre.cmor</issue_title>
<issue_description># Phase 3: Deferred Features from fre.cmor

This document tracks features from open fre.cmor pull requests that are intentionally deferred for future implementation in fremorizer. Each item corresponds to a specific PR in the fre-cli repository.

Purpose

Phase 3 features represent enhancements and improvements that were in progress in the fre.cmor submodule. These are deferred to focus on:

  1. Establishing a stable, working independent fremorizer package (Phase 1-2)
  2. Validating equivalence with existing fre-cli functionality (Phase 2.5)
  3. Ensuring CI/CD pipelines are robust and reliable

Once the foundation is solid and equivalence testing is complete, these features can be incorporated systematically.

Phase 3 Items

1. PR ilaflott/fremorizer#826: Replace nccmp with netCDF4 in tests ✅ COMPLETED

2. PR ilaflott/fremorizer#832: Harden branded-variable disambiguations

3. PR ilaflott/fremorizer#833: Improved omission tracking

4. PR ilaflott/fremorizer#834: New fremor init command for config fetching

5. PR ilaflott/fremorizer#836: Informative error on mip_era/table format mismatch

6. PR ilaflott/fremorizer#837: Accept CF calendar aliases (noleap/365_day, etc.)

7. PR ilaflott/fremorizer#838: CMIP7 flavored tests

8. PR ilaflott/fremorizer#846: Variable list semantics (map modeler vars to MIP table names)

9. PR ilaflott/fremorizer#817: Update cmor to 3.14.2

Implementation Strategy

When ready to implement Phase 3 features:

  1. Create individual GitHub issues for each item above with:

    • Link to the original fre-cli PR
    • Description of the feature/fix
    • Any fremorizer-specific considerations
    • Testing requirements
  2. Prioritize based on:

    • User impact (e.g., PR ilaflott/fremorizer#826 fixes current test failures)
    • Dependencies between features
    • Alignment with CMIP6/CMIP7 timelines
  3. Implementation approach:

    • Review the original PR in fre-cli for implementation details
    • Adapt code to fremorizer's independent package structure
    • Ensure all changes maintain test coverage
    • Update documentation as needed
    • Validate no regressions in existing functionality
  4. Testing requirements:

    • All existing tests must continue to pass
    • New tests should be added for new features
    • Phase 2.5 equivalence tests should still pass after each feature addition

Notes

  • Phase 2.5 (equivalence testing with fre-cli) should be completed before implementing Phase 3 features
  • Each Phase 3 feature should be implemented in a separate PR for easier review and rollback if needed
  • Consider creating a project board to track Phase 3 implementation progress

References

Comments on the Issue (you are @claude[agent] in this section)

@Claude Claude AI linked an issue Apr 14, 2026 that may be closed by this pull request
@Claude Claude AI requested a review from ilaflott April 14, 2026 02:21
@ilaflott ilaflott force-pushed the claude/add-deferred-features-from-fre-cmor branch 2 times, most recently from 893e0ad to 0ff7d46 Compare April 14, 2026 02:37
@ilaflott ilaflott marked this pull request as ready for review April 14, 2026 02:50
@ilaflott ilaflott force-pushed the claude/add-deferred-features-from-fre-cmor branch from 0ff7d46 to be730d2 Compare April 14, 2026 02:50
Claude AI and others added 3 commits April 13, 2026 23:01
@ilaflott ilaflott force-pushed the claude/add-deferred-features-from-fre-cmor branch from be730d2 to 5061dc3 Compare April 14, 2026 03:01
@ilaflott ilaflott closed this Apr 14, 2026
@ilaflott ilaflott deleted the claude/add-deferred-features-from-fre-cmor branch April 14, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deferred Features from fre.cmor

2 participants