Skip to content

[WIP] Improve variable list semantics for MIP table names#74

Open
Copilot wants to merge 3 commits intomainfrom
copilot/update-variable-list-handling
Open

[WIP] Improve variable list semantics for MIP table names#74
Copilot wants to merge 3 commits intomainfrom
copilot/update-variable-list-handling

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

  • Port variable list semantics from fre-cli PR #846 (local_var reads data, target_var for MIP lookups)
  • Fix omission tracking clash: CLI only raises ClickException for fatal errors (result < 0), not partial failures
  • Update make_simple_varlist: non-MIP vars get empty string value, MIP vars get self-mapped value
  • Update CLI varlist filter tests for new semantics
  • Update make_simple_varlist unit test for MIP table filter
  • INCOMPLETE: test_make_simple_varlist_mip_table_no_match test needs update — it expects None return but now gets dict with empty-string values since non-MIP vars are included instead of filtered out. Fix: update assertion to expect a dict with empty string values instead of None.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
fremorizer/cmor_finder.py 71.42% 2 Missing ⚠️
fremorizer/cli.py 66.66% 1 Missing ⚠️
fremorizer/cmor_mixer.py 90.90% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   95.03%   94.53%   -0.51%     
==========================================
  Files          10       10              
  Lines        1310     1317       +7     
==========================================
  Hits         1245     1245              
- Misses         65       72       +7     
Files with missing lines Coverage Δ
fremorizer/cli.py 99.05% <66.66%> (-0.95%) ⬇️
fremorizer/cmor_mixer.py 91.28% <90.90%> (-0.37%) ⬇️
fremorizer/cmor_finder.py 95.69% <71.42%> (-4.31%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed3c0e...db3c60b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot stopped work on behalf of ilaflott due to an error April 14, 2026 18:12
Copilot AI requested a review from ilaflott April 14, 2026 18:12
@ilaflott ilaflott marked this pull request as ready for review April 14, 2026 18:13
…port of fre-cli PR #846)

Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/0b3522fa-445e-4018-96db-2b71ae100422

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
@ilaflott ilaflott force-pushed the copilot/update-variable-list-handling branch from 795cd08 to 9a94bec Compare April 14, 2026 18:15
Copilot AI and others added 2 commits April 14, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new features: Variable list semantics (map modeler vars to MIP table names)

3 participants