Skip to content

Support get_origin(Union[...]) in python 3.14 #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 2 commits into from
Jan 18, 2026
+8 −1
Merged

Support get_origin(Union[...]) in python 3.14 #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
869e193
Support `get_origin(Union[...])` in python 3.14
leon-sony Jan 17, 2026
a2e4870
Fix lint
ilevkivskyi Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test_typing_inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,7 @@ def test_origin(self):
if GENERIC_TUPLE_PARAMETRIZABLE:
tp = List[Tuple[T, T]][int]
self.assertEqual(get_origin(tp), list if NEW_TYPING else List)
self.assertIs(get_origin(Union[str, int]), typing.Union)

def test_parameters(self):
T = TypeVar('T')
Expand Down
8 changes: 7 additions & 1 deletion typing_inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,13 @@ def get_origin(tp):
get_origin(List[Tuple[T, T]][int]) == list # List prior to Python 3.7
"""
if NEW_TYPING:
if isinstance(tp, typingGenericAlias):
if (
isinstance(tp, typingGenericAlias) or
# In Python 3.14, Union[...] is not an instance of
# typingGenericAlias, but it does have an `__origin__`, so check for
# Unions explicitly.
is_union_type(tp)
):
return tp.__origin__ if tp.__origin__ is not ClassVar else None
if tp is Generic:
return Generic
Expand Down