[SimpleXML] Fix namespace filter on element returned by addChild() - #259
Closed
iliaal wants to merge 1 commit into
Closed
[SimpleXML] Fix namespace filter on element returned by addChild()#259iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
The SimpleXMLElement wrapper returned by addChild() stored the QName prefix as the iteration namespace filter in href mode, so property accesses on the returned element compared the prefix against namespace hrefs and never matched the children that asXML() shows. Derive the filter from the namespace actually attached to the new node and use prefix mode; sibling audit found no other call site passing a prefix in href mode.
Owner
Author
|
Promoted upstream as php#23599. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimpleXMLElement::addChild() stored the QName prefix as the iteration namespace filter in href mode, so property access on the returned element compared the prefix against namespace hrefs and never matched children that asXML() shows: $c->inner was empty. The element now derives its filter from the namespace attached to the created node (newnode->ns->prefix) and switches to prefix mode, which also covers qname prefixes differing from the resolved namespace. A node_as_zval_str()/node_as_zval() call-site audit found no other offender; a new phpt fails unpatched and passes patched.