Skip to content

Comments

feat: improve pstates UI#896

Merged
ilya-zlobintsev merged 21 commits intoilya-zlobintsev:masterfrom
makarov-roman:improve-pstates-ui
Feb 15, 2026
Merged

feat: improve pstates UI#896
ilya-zlobintsev merged 21 commits intoilya-zlobintsev:masterfrom
makarov-roman:improve-pstates-ui

Conversation

@makarov-roman
Copy link
Contributor

@makarov-roman makarov-roman commented Feb 2, 2026

addresses #894
image
changes:

  1. hide checkboxes instead of disabling them
  2. do not render list when there are no values
  3. move power_state_row to dedicated file (maybe it's my habbit, but I don't really like to have multiple components in one file)
  4. remove global sensitive flag, instead all inactive pstates will be dimmed via default css class.
  5. move active arrow label to the left to make it more obvious where it points ( if you stretch all UI on big screen it might be hard to tell). Also it prevents list width from jumping by couple of pixels.
  6. add PageSectionExpander component and wrap pstates frame into that, it's copy-paste of PageSection mostly. I've tried to implement it first on PageSection, but it was looking very hacky.
  7. switch to monospace to improve consistency

@makarov-roman makarov-roman marked this pull request as ready for review February 2, 2026 17:45
Copy link
Owner

@ilya-zlobintsev ilya-zlobintsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes there might not be info about an active power state (in particular, on all Intel and some AMD devices), currently it looks a bit weird in such a scenario, there should not be a gap:

Image

Also, is it expected that the expander button is a bit out of bounds compared to the rest of the UI? (Maybe it's fine, it's just different compared to the rest of the elements)

@makarov-roman
Copy link
Contributor Author

Also, is it expected that the expander button is a bit out of bounds compared to the rest of the UI?

I wanted to align headers themselves
image

@makarov-roman
Copy link
Contributor Author

fixed
image

@makarov-roman makarov-roman marked this pull request as draft February 14, 2026 15:23
@makarov-roman makarov-roman marked this pull request as ready for review February 14, 2026 15:36
Copy link
Owner

@ilya-zlobintsev ilya-zlobintsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilya-zlobintsev ilya-zlobintsev merged commit b4740fd into ilya-zlobintsev:master Feb 15, 2026
14 of 30 checks passed
@makarov-roman makarov-roman deleted the improve-pstates-ui branch February 15, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants