Document a few missing safety invariants #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the internal macro defining the inherently available `Texel` implementations. The macro calls now take an additional unsafe keyword and comment to justify that usage. When provided the call allows arbitrary types but otherwise requires the type to be `bytemuck::Pod` at const time. This works around having to surface all kinds of different features covering parts of bytemuck's SIMD implementations. I expect that some of this will become less intricate if `#[cfg(rust-version())]` (or w/e it is spelled) will be supported since this would get rid of the need for such feature flags in bytemuck. Iff they bump to `2` as to only support compiler versions that support such a configuration macro. Which.. yeah. Anyways we can at least add implementations for new SIMD types as they are stabilized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.