Lift shared canvas into image-canvas #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the complexity of interactions between pipeline parts by ensuring that all this is available in advance, in one struct. This removes a few parameters from function interfaces.
The main API change is that `add_plane*` in the public conversion interface takes our own `BytePlane` types instead of the wrapped internal `image-texel` plane types. We made the internal shader operation of conversion independent from the color model of a `Canvas`, i.e. we can operate on arrays described by `PlaneBytes` layouts each. Instead of a signular description of one image we have a (coherent) collection of texel components coming from some input planes and flowing to some output planes. By making this description internal to the converter we also enable flexible Yuv conversion, mixed-depth alpha, and dynamically associated filter planes, depth-buffers, etc in subsequent PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most crucially this should allow to interact with the color conversion. This is complete when tests demonstrate the basic behavior, that is reading from a shared image that is in fact not modified at all through synchronization.
Future extensions