Qualify RGB conversions with colour-science #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous attempts at reproducing the numbers failed to use the argument for marking inputs such that the transfer function must be applied, which is *not* the default despite what you might expect when hearing sRGB and similar. Thus the conversion matrices obviously differed. This reproduces floats up to 3 digits which is .. not quite as good as I had expected but I think the Python library is using f64 for everything where our matrices are still f32 calculations and such intermediate results. A look at using more precise and faster matrix multiplication with explicit instructions should be done at a later point.
197g
force-pushed
the
matching-colour-science
branch
from
a61953a to
ffec2e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous attempts at reproducing the numbers failed to use the argument for marking inputs such that the transfer function must be applied, which is not the default despite what you might expect when hearing sRGB and similar. Thus the conversion matrices obviously differed.
This reproduces floats up to 3 digits which is .. not quite as good as I had expected but I think the Python library is using f64 for everything where our matrices are still f32 calculations and such intermediate results. A look at using more precise and faster matrix multiplication with explicit instructions should be done at a later point.