Use {int}::to_le_bytes in WriteBytesExt#204
Merged
Merged
Conversation
Contributor
Author
|
Like #203, I can't replicate the CI failure locally. Any ideas? |
Contributor
Author
|
See #206 for CI failure cause and possible fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
WriteBytesExtcurrently uses a hand-rolled bit-shifting algorithm to divide and conquer unsized integers into little-endian bytes, before passing them toWrite::write_all. While the implementation is correct,coreprovides{int}::to_le_bytes, which may optimise better (since it more clearly conveys intent to the optimiser), and is definitely more likely to be tested and maintained.Solution
{int}::to_le_bytesfor the implementations ofWriteBytesExt::write_le