Switched to BTreeMap and BTreeSet#207
Merged
Merged
Conversation
`HashMap` and `HashSet` are not available in `no_std`
Contributor
Author
|
See #206 for CI failure details. |
kornelski
approved these changes
May 15, 2025
fintelia
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
For
no_stdcompatibility it would be useful to move away fromHashMapandHashSet, and instead use eitherhashbrownoralloc::collections::BTreeMap/Set. Since the cases whereHashMapandHashSetare used are compatible withBTreeMapandBTreeSet, we should use those instead of introducing a new dependency.Solution
std::collections::HashMapwithalloc::collections::BTreeMapstd::collections::HashSetwithalloc::collections::BTreeSetcargo bench rgb_frame(the only benchmark that hits this code-path).Notes
On my Intel i5-1240p laptop I observed no difference in performance due to this PR:
It's possible other platforms may show a more pronounced performance delta, but without evidence I think the tradeoff between possible performance loss vs increased platform compatibility is worth it here.