fix: correct interpretation of extra samples with unspecified type of alpha#390
Open
soyosaki wants to merge 4 commits into
Open
fix: correct interpretation of extra samples with unspecified type of alpha#390soyosaki wants to merge 4 commits into
soyosaki wants to merge 4 commits into
Conversation
Author
|
The latest commit should address the decode issue related to TIFF data in RGB with more than 1 extra samples. Clippy warning appear unrelated to the changes on the current branch. |
Author
|
Merged latest main, now all checks are passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit should correct how TIFF images with samples count larger than photometric samples count are interpreted. For example, if a TIFF image claims a RGB photometric interpretation, a
8 8 8 8bits-per-sample array, and an unspecified extra samples field (i.e.ExtraSamples = 0), the current commit should interpret the image as an RGBA image with the extra sample be treated as the alpha channel of the image, whereas currently the crate would interpret it as a RGB image and produce a corrupted pixel map.The test
extra_bits_rgbis fixed together, and it should now align with the logic ofextra_bits_grayandwrite_extra_bits_image.