Memory limits for HDR decoding with fixed header size limit #2723
+58
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Radiance HDR decoder retains a decoded form of the complete image header; imposing a generous hard limit on the header length ensures that the decoder will never allocate an extreme amount of memory, while being unlikely to reject any but pathological images.
The decoder allocates a temporary buffer to hold a scanline; this could increase the required decoding space by a significant fraction if the image has height 1 and very large width.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2713 in limiting the amount of memory allocated by the .hdr file decoder. This approach sets a hard limit on the maximum length of the image header, thereby limiting the amount of memory the decoder could allocate to parse and store the header's contents. If there ever are HDR files which have very long headers, it would not be difficult to explicitly configure limits, like #2713, instead.