Fix underflows and panics around Gaussian blur for empty images#3007
Open
RunDevelopment wants to merge 1 commit into
Open
Fix underflows and panics around Gaussian blur for empty images#3007RunDevelopment wants to merge 1 commit into
RunDevelopment wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses M12 from #2954.
The issue was some operations inside the various functions implementing Gaussian blur assumed that there is at least one pixel. This is obviously not the case, so underflow and panics were possible.
I fixed this by changing the type representing the size of an image to filter. The type now represents non-empty image sizes. This solves the issue by making the assumption true.
During testing, I also found a bug in
GenericImageView::Pixels. This iterator didn't specify its stop condition correctly, which made OOB panics possible. I fixed that too.