-
Notifications
You must be signed in to change notification settings - Fork 168
Make external dependencies optional #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
making DistanceFrom public isn't related to optional dependencies |
My bad @cospectrum that was for another commit. I removed it. |
cospectrum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is 1 new image hash function on master which does not require dct and there will be more. So could you please replace image_hash feature with fft feature (not dct, since fft is the main shared dependency, this will help minimise future feature bloat). You will need to cfg feature on hash function instead of the entire module.
|
I started working on this and it causes a cascade of warnings if/when the feature is removed. Would you rather I go through add |
|
Nvm I think a mixture of |
Merge conflict resolution, added an extra space which fmt did not like
|
I don't like unused imports. They still may slow down compile time I think. Lets put entire modules such that phash, signals, bits behind the feature |
src/image_hash/signals.rs
Outdated
| Image::from_vec(img.width(), img.height(), img_buf).unwrap() | ||
| } | ||
|
|
||
| #[allow(dead_code)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try to remove allow(dead_code) in this file
|
1 thread is remaining. You can do it! |
|
...sorry about that I got pulled away from the computer for a bit. |
Made ab_glyph and rustdct optional and the respective modules they are being used in features. The only other dependency that doesn't span multiple modules is
approxwhich would make geometric_transformations a feature if we wanted to make it optional.note: this will break other people's use of this library if they have the
default-featuresset to false and are using eitherdrawing::textorimage_hash