Fix panic when prediction calculation is invalid #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fintelia
approved these changes
Mar 7, 2025
.github/workflows/rust.yml
Outdated
| @@ -8,7 +8,7 @@ on: | |||
|
|
|||
| jobs: | |||
| build: | |||
| runs-on: ubuntu-latest | |||
| runs-on: ubuntu-22.04 | |||
There was a problem hiding this comment.
I saw that the cross_compile jobs failed due to Ubuntu version, but do you know whether this one can stay Ubuntu latest?
There was a problem hiding this comment.
I'll see if the issue on 24.04 can be fixed, may just be a package that changed its name
richard-viney
force-pushed
the
fix-panic-in-invalid-prediction-shift
branch
from
00d6bd9 to
2059842
Compare
|
Thanks! |
|
Thanks for merging! If it's possible to release a v0.3.2 at some stage that'd be great, but no urgency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was found during fuzz testing of a library that depends on
jpeg-decoder, on the following line:jpeg-decoder/src/decoder/lossless.rs
Line 112 in e70564b
It's triggered when the math underflows in the situation that
scan.point_transformisn't less thanframe.precision.This PR adds a check in the parser that errors when this situation is detected, as well as the test case generated by the fuzz tester.
(I also changed to explicitly specify Ubuntu 22.04 in CI due to failures running on 24.04).