Skip to content

Fix napari-imagej tests #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gselzer merged 3 commits into from
Mar 31, 2025
Merged

Fix napari-imagej tests #325

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d526c3f
Examining JVM shutdown
gselzer Mar 31, 2025
13ea2b9
Trim down the solution
gselzer Mar 31, 2025
7b8d8d1
Add documentation
gselzer Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/napari_imagej/widgets/napari_imagej.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,15 @@ def return_search_bar():
# Start constructing the ImageJ instance
self.ij_initializer.start()

# Ensure widget closes when JVM closes
# Without this call we are prone to segfaults during JVM shutdown
when_jvm_stops(self.close)

def close(self):
# Ensure setup completed
self.wait_for_finalization()
# Close things down
super().close()
self.ij_initializer._clean_subscribers()

def wait_for_finalization(self):
Expand Down
Loading