Custom Banner Class#24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to wrap banners in customizable
divelements with CSS classes, along with enhancements to the admin interface, data structure, and code quality. The changes ensure backward compatibility and include updates to both PHP and JavaScript for seamless integration.New Feature: Div Wrapper for Banners
wrap_banner_html()utility method to wrap banner HTML in adivwith a custom CSS class, ensuring consistent implementation across all banner types. (includes/class-iwz-banner-container.php)wrap_banner_html()function, allowing banners to include the optional wrapper class. (includes/class-iwz-banner-container.php) [1] [2] [3] [4] [5] [6] [7] [8] [9]Admin Interface Enhancements
includes/class-iwz-banner-container-settings.php) [1] [2]updateBannerCount()to dynamically include the "Wrapper CSS Class" field for new banners. (includes/class-iwz-banner-container-settings.php) [1] [2]Data Structure Updates
wrapper_classfield, with proper sanitization to ensure security. (includes/class-iwz-banner-container-settings.php)Documentation and Metadata
1.8.2and documented the new feature in theCHANGELOG.mdfile. (iwz-banner-container-plugin.php,CHANGELOG.md) [1] [2] [3]