Sticky footer headerfooter background#29
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds sticky footer functionality and customizable wrapper background colors for header and footer banners, including corresponding admin UI updates and CSS enhancements.
- Enhanced CSS to support sticky footer banners and default header/footer wrapper backgrounds.
- Updated PHP to register
wrapper_bg_colorandstickysettings, wrap banners with inline background styles, and bump version to 1.9.5. - Improved admin interface with color picker inputs and a sticky checkbox, plus documentation and changelog updates.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| public/css/iwz-banner-container-public.css | Added CSS rules for sticky footer banners and wrapper background color support |
| iwz-banner-container-plugin.php | Updated plugin version constant to 1.9.5 |
| includes/class-iwz-banner-container.php | Extended wrap_banner_html to accept sticky and wrapper_bg_color, updated display methods |
| includes/class-iwz-banner-container-welcome.php | Updated welcome page to mention background color and sticky options for header/footer |
| includes/class-iwz-banner-container-settings.php | Registered new wrapper_bg_color and sticky settings, added UI controls in settings page |
| README.md | Reflected new header naming convention |
| DEVELOPMENT.md | Clarified header location description in development guide |
| CHANGELOG.md | Documented new features and fixes in version 1.9.5 |
Comments suppressed due to low confidence (3)
includes/class-iwz-banner-container-settings.php:171
- Consider adding automated tests to cover the new wrapper background color setting registration to ensure defaults and sanitization behave as expected.
register_setting(
'iwz_banner_container_settings',
'iwz_banner_' . $location_key . '_wrapper_bg_color',
DEVELOPMENT.md:145
- [nitpick] The nested parentheses make this line hard to read; consider rephrasing to avoid multiple nested parentheses, e.g., 'Header (Top of page after
<body>tag)'.
1. **wp_head** - Header (Top of page (after `<body>` tag))
public/css/iwz-banner-container-public.css:101
- The position declaration inside the media query duplicates the base rule; removing this redundant line can simplify maintenance.
position: fixed !important;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new features, enhancements, and bug fixes to the
iwz-banner-container-plugin. The most notable updates include the addition of sticky footer banners, customizable wrapper background colors for header and footer banners, and improvements to the plugin's UI and user experience. The changes also include updates to CSS for responsive design and sticky positioning, as well as modifications to the plugin's codebase to support these new functionalities.New Features and Enhancements:
includes/class-iwz-banner-container-settings.php[1]includes/class-iwz-banner-container.php[2]public/css/iwz-banner-container-public.css[3]#fffffffor header,#161515for footer). (includes/class-iwz-banner-container-settings.php[1]includes/class-iwz-banner-container.php[2]public/css/iwz-banner-container-public.css[3]includes/class-iwz-banner-container-settings.phpincludes/class-iwz-banner-container-settings.phpR739-R780)Bug Fixes:
CHANGELOG.mdCHANGELOG.mdR5-R23)CHANGELOG.mdCHANGELOG.mdR5-R23)UI and UX Improvements:
CHANGELOG.mdCHANGELOG.mdR5-R23)DEVELOPMENT.md[1]README.md[2]includes/class-iwz-banner-container-welcome.php[3]Codebase Updates:
wrap_banner_htmlmethod to include new parameters for sticky banners and background colors. (includes/class-iwz-banner-container.php[1] [2]1.9.5to reflect the new features and fixes. (iwz-banner-container-plugin.php[1] [2]