Banner Alignment Issues#31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to improve the alignment and styling of footer banners by replacing JavaScript-based solutions with CSS-based approaches. The JavaScript method for iframe alignment has been deprecated, and flexbox is now used for consistent alignment. Additionally, the alignment class prefix has been updated for clarity.
JavaScript Removal:
output_banner_alignment_scriptmethod, which used JavaScript to fix iframe alignment issues. The alignment is now handled through CSS in the child theme. (includes/class-iwz-banner-container.php, includes/class-iwz-banner-container.phpR339-R372)CSS Enhancements for Alignment:
align-left,align-center,align-right) using flexbox. These rules ensure proper alignment and responsiveness. (public/css/iwz-banner-container-public.css, [1] [2]display: blockfrom the general banner styles to allow flexbox alignment. (public/css/iwz-banner-container-public.css, public/css/iwz-banner-container-public.cssL96-R98)Codebase Simplification:
iwz-align-toalign-for better readability and consistency. (includes/class-iwz-banner-container.php, includes/class-iwz-banner-container.phpL802-R835)