Blabber footer alignment#37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the
iwz-banner-container-plugin, focusing on improving banner alignment behavior, standardizing unique ID logic for banners, and enhancing code quality and user experience. The most notable changes include updates to banner rendering logic, CSS enhancements for desktop and mobile alignment, and modifications to the plugin version and constants.Banner Rendering Logic Enhancements:
display_blabber_footer_start_banner()method to initialize banner indexing at 1 instead of 0 for consistency across banner types. (F4be54ddL390R390)wrap_banner_html()method to include unique IDs for banners based on their index and location, improving targeting and alignment.CSS Improvements:
left,center,right) using flexbox and media queries, ensuring alignment settings are respected for screens 769px and above. [1] [2]Documentation Updates:
README.mdto clarify desktop vs. mobile behavior and alignment settings, providing better guidance for plugin users.Version and Constants:
1.9.15and corresponding constants to reflect the latest changes. [1] [2]Changelog Additions:
CHANGELOG.md, including bug fixes, enhancements, and technical improvements for versions1.9.13through1.9.15.