Footer Banner Age Cookie Patch#38
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Banner Container Plugin to ensure footer banners are properly hidden and shown based on age verification, bumps the plugin version to 1.9.20, and records these changes in the changelog.
- Added
code-blockclass to banner wrapper to enable age verification targeting. - Bumped plugin version from 1.9.15 to 1.9.20 in header and constant.
- Updated CHANGELOG with details on age verification and styling enhancements.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| iwz-banner-container-plugin.php | Bumped plugin version in header and IWZ_BANNER_CONTAINER_VERSION |
| includes/class-iwz-banner-container.php | Added code-block class to $wrapper_classes in wrap_banner_html |
| CHANGELOG.md | Documented version 1.9.20 updates including age verification fixes |
Comments suppressed due to low confidence (2)
CHANGELOG.md:13
- [nitpick] The changelog entry states the
code-blockclass is applied to both inner and outer wrapper divs, but the diff only adds it to the outer wrapper. Please update the changelog or adjust the code to accurately reflect where the class is applied.
* Technical Note: The `code-block` class is now applied to both inner banner div and outer wrapper div for styled banners to ensure JavaScript targeting works correctly.
includes/class-iwz-banner-container.php:949
- The
code-blockclass is now applied to every banner wrapper, not just footer banners. If the intention is to target only footer or specific banner types, consider moving this class addition inside the conditional that checks forwp_footeror matching$wrapper_type.
$wrapper_classes = 'iwz-banner-wrapper iwz-' . $wrapper_type . '-wrapper code-block';
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces updates to improve the functionality and consistency of banner handling in the
iwz-banner-container-plugin. The changes primarily address issues with age verification for footer banners, enhance code quality, and update versioning.Age Verification and Banner Functionality Enhancements:
CHANGELOG.md: Documented fixes and enhancements, including adding thecode-blockclass to ensure footer banners are properly hidden/shown based on age verification settings.includes/class-iwz-banner-container.php: Updated thewrap_banner_htmlmethod to include thecode-blockclass in$wrapper_classes, enabling proper JavaScript targeting for styled banners.Version Updates:
iwz-banner-container-plugin.php: Updated the plugin version to1.9.20in both the plugin header and theIWZ_BANNER_CONTAINER_VERSIONconstant. [1] [2]