Skip to content

Footer Banner Age Cookie Patch#38

Merged
jasperf merged 1 commit into
mainfrom
footer-banner-cookie-class
Jul 16, 2025
Merged

Footer Banner Age Cookie Patch#38
jasperf merged 1 commit into
mainfrom
footer-banner-cookie-class

Conversation

@jasperf

@jasperf jasperf commented Jul 15, 2025

Copy link
Copy Markdown
Contributor

This pull request introduces updates to improve the functionality and consistency of banner handling in the iwz-banner-container-plugin. The changes primarily address issues with age verification for footer banners, enhance code quality, and update versioning.

Age Verification and Banner Functionality Enhancements:

  • CHANGELOG.md: Documented fixes and enhancements, including adding the code-block class to ensure footer banners are properly hidden/shown based on age verification settings.
  • includes/class-iwz-banner-container.php: Updated the wrap_banner_html method to include the code-block class in $wrapper_classes, enabling proper JavaScript targeting for styled banners.

Version Updates:

@jasperf jasperf requested a review from Copilot July 16, 2025 06:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Banner Container Plugin to ensure footer banners are properly hidden and shown based on age verification, bumps the plugin version to 1.9.20, and records these changes in the changelog.

  • Added code-block class to banner wrapper to enable age verification targeting.
  • Bumped plugin version from 1.9.15 to 1.9.20 in header and constant.
  • Updated CHANGELOG with details on age verification and styling enhancements.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
iwz-banner-container-plugin.php Bumped plugin version in header and IWZ_BANNER_CONTAINER_VERSION
includes/class-iwz-banner-container.php Added code-block class to $wrapper_classes in wrap_banner_html
CHANGELOG.md Documented version 1.9.20 updates including age verification fixes
Comments suppressed due to low confidence (2)

CHANGELOG.md:13

  • [nitpick] The changelog entry states the code-block class is applied to both inner and outer wrapper divs, but the diff only adds it to the outer wrapper. Please update the changelog or adjust the code to accurately reflect where the class is applied.
* Technical Note: The `code-block` class is now applied to both inner banner div and outer wrapper div for styled banners to ensure JavaScript targeting works correctly.

includes/class-iwz-banner-container.php:949

  • The code-block class is now applied to every banner wrapper, not just footer banners. If the intention is to target only footer or specific banner types, consider moving this class addition inside the conditional that checks for wp_footer or matching $wrapper_type.
			$wrapper_classes = 'iwz-banner-wrapper iwz-' . $wrapper_type . '-wrapper code-block';

@jasperf jasperf merged commit b0aba2b into main Jul 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants