Fix mobile banner alignment and height restrictions for Blabber Footer Start banners#40
Closed
Copilot wants to merge 2 commits into
Closed
Fix mobile banner alignment and height restrictions for Blabber Footer Start banners#40Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Contributor
|
@copilot these suggestions do take into account that we set banners' alignment in the dashboard / on the settings page and so are dynamic ? |
…r Start banners Co-authored-by: jasperf <344138+jasperf@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix mobile Blabber Footer Start banner cut-off and alignment issues
Fix mobile banner alignment and height restrictions for Blabber Footer Start banners
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Blabber Footer Start banners had two critical issues on mobile devices:
Root Cause
The CSS media query for mobile devices (
max-width: 768px) contained overly restrictive rules:Solution
1. Fixed Height Restrictions
Added dedicated mobile CSS override to allow flexible banner heights:
2. Fixed Mobile Alignment
Completely rewrote mobile alignment logic to respect individual banner settings:
Impact
Before Fix ❌
After Fix ✅
Testing
Added comprehensive manual testing documentation to README.md including:
Backward Compatibility
✅ Fully backward compatible
Files Changed
public/css/iwz-banner-container-public.css- Core mobile CSS fixesREADME.md- Added testing documentation and updated examplesThis fix ensures that Blabber Footer Start banners display correctly on mobile devices while respecting user-configured alignment settings and supporting standard mobile banner dimensions.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/PHPCSStandards/PHP_CodeSniffer/zipball/5b5e3821314f947dd040c70f7992a64eac89025c/usr/bin/php8.3 -n -c /tmp/CxXwgs /usr/bin/composer install(http block)If you need me to access, download, or install something from one of these locations, you can either:
This pull request was created as a result of the following prompt from Copilot chat.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.