Skip to content

Remove widget and napari plugin#305

Open
psobolewskiPhD wants to merge 4 commits into
imaging-formats:mainfrom
psobolewskiPhD:remove_widget
Open

Remove widget and napari plugin#305
psobolewskiPhD wants to merge 4 commits into
imaging-formats:mainfrom
psobolewskiPhD:remove_widget

Conversation

@psobolewskiPhD

Copy link
Copy Markdown

In lieu of the widget and napari plugin being in this repo, remove them in favor of: https://github.com/imaging-formats/ome-types-widget

@codecov

codecov Bot commented Apr 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@psobolewskiPhD

psobolewskiPhD commented Apr 5, 2026

Copy link
Copy Markdown
Author

The test fails are due to 4.0.0 of pytest-mypy-plugins.
Breaking changes:

  • Breaking: Errors are now ignored in site-packages by default. The --mypy-only-local-stub flag
    has been removed and replaced with --mypy-no-silence-site-packages which can be used to restore
    the previous behavior if needed. This change was made to avoid errors being raised when enabling
    certain mypy options, e.g. the explicit-override error code or the --disallow-subclassing-any
    flag, which resulted in violations due to these not being supported with the stubs provided by
    typeshed for the standard library. In addition, this affected other error codes or flags for some
    third-party libraries in django-stubs.
  • Breaking: When running in a subprocess (the default), PYTHONPATH is no longer set. With the
    above change, violations would still be raised in the main module for a test case, but those that
    were flagged in imported modules would no longer be raised. This was because these modules were
    being added to PYTHONPATH which caused mypy to treat them as belonging in site-packages and not
    as part of the first-party package. The new --mypy-modify-pythonpath flag can be used to revert
    to the previous behavior if needed.

Looks like mypy-only-local-stub can just be removed and the minimum pytest-mypy-plugins bumped?
Ah, but moving to 4.0.0 would drop py3.9...
Could stop-gap by adding a upper bound in this PR and then releasing it in #290 once new version of https://github.com/PyCQA/docformatter is released unblocking py314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant