Skip to content

Support Laravel 12#32

Open
adrianmihaila wants to merge 1 commit intoimanghafoori1:mainfrom
adrianmihaila:support-laravel12
Open

Support Laravel 12#32
adrianmihaila wants to merge 1 commit intoimanghafoori1:mainfrom
adrianmihaila:support-laravel12

Conversation

@adrianmihaila
Copy link
Copy Markdown

@adrianmihaila adrianmihaila commented Apr 28, 2025

Summary by Sourcery

Add support for Laravel 12 by updating dependencies and adjusting related code.

Enhancements:

  • Inject the FakeConnection instance into the FakeGrammar constructor.
  • Add the compileTableListing method to FakeSchemaGrammar.
  • Apply minor code style fixes and remove empty method bodies.

Build:

  • Update illuminate/database and illuminate/events dependency constraints in composer.json to include 12.*.

Summary by CodeRabbit

  • New Features

    • Added a method to support table listing functionality in schema operations.
  • Style

    • Improved code formatting and consistency across multiple files, including whitespace cleanup and standardized spacing.
  • Chores

    • Updated dependency version constraints to support newer versions of required packages.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 28, 2025

Reviewer's Guide by Sourcery

This pull request adds support for Laravel 12 by implementing the compileTableListing method in FakeSchemaGrammar and updating the composer dependencies.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Implement compileTableListing method to support Laravel 12.
  • Add compileTableListing method which wraps the parent method call and returns a stringy representation.
  • Update compileGetAllTables to use the same stringy wrapper.
src/FakeSchemaGrammar.php
Update composer dependencies to include Laravel 12.
  • Allow illuminate/database and illuminate/events up to version 12.*.
composer.json
Perform minor code style and formatting adjustments.
  • Adjust spacing around anonymous class instantiation.
  • Fix spacing in foreach loops and conditional checks.
  • Adjust spacing around type casting.
  • Adjust spacing around object property access.
  • Add connection instance to FakeGrammar constructor calls.
src/FakeDB.php
src/FakeSchemaGrammar.php
src/FakeConnection.php

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 28, 2025

Walkthrough

The changes update dependency version constraints in composer.json to support Laravel 12.x, alongside code formatting improvements and minor constructor argument adjustments in several PHP source files. In src/FakeConnection.php, object instantiations are updated to explicitly pass arguments, and formatting is improved. In src/FakeDB.php, extraneous spaces and redundant parentheses are removed for consistency. src/FakeSchemaGrammar.php receives whitespace cleanup, minor formatting tweaks, and the addition of a new public method, compileTableListing, which returns information about table listings.

Changes

File(s) Change Summary
composer.json Extended version constraints for "illuminate/database" and "illuminate/events" to include 12.*
src/FakeConnection.php Updated object instantiations to use parentheses and pass arguments; reformatted code and removed empty else block
src/FakeDB.php Removed extraneous spaces and redundant parentheses for consistent formatting; no logic changes
src/FakeSchemaGrammar.php Cleaned up whitespace and formatting; added new method compileTableListing

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FakeSchemaGrammar

    User->>FakeSchemaGrammar: compileTableListing(schema, schemaQualified)
    FakeSchemaGrammar->>FakeSchemaGrammar: Call parent::compileGetAllTables(schema, schemaQualified)
    FakeSchemaGrammar-->>User: Return ['type' => 'getAllTables', 'sql' => ...]
Loading

Poem

In the warren of code, we hop and we trim,
Spaces and brackets, now tidy and slim.
A new method appears, for tables to show,
Version twelve joins the burrow, ready to go!
With paws on the keys and a whiskered delight,
We celebrate clean code, from morning till night.
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6255bed and 88c8c9f.

📒 Files selected for processing (4)
  • composer.json (1 hunks)
  • src/FakeConnection.php (2 hunks)
  • src/FakeDB.php (10 hunks)
  • src/FakeSchemaGrammar.php (4 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (2)
src/FakeDB.php (1)
tests/OrderByTest.php (1)
  • orderBy (29-44)
src/FakeConnection.php (3)
src/FakePDO.php (1)
  • FakePDO (5-16)
src/FakeGrammar.php (1)
  • FakeGrammar (9-115)
src/FakeSchemaGrammar.php (1)
  • FakeSchemaGrammar (10-188)
🔇 Additional comments (6)
composer.json (1)

19-20: Dependency versioning correctly updated for Laravel 12 support

The version constraints for illuminate/database and illuminate/events have been extended to include version 12.*. This change properly implements Laravel 12 support while maintaining backward compatibility with previous versions.

src/FakeDB.php (1)

66-66: Style improvements for consistent coding style

The changes remove spaces between function names and opening parentheses, and remove spaces after negation operators, creating a more consistent code style throughout the file.

Also applies to: 82-82, 192-192, 197-197, 365-365, 439-439, 448-448, 508-508, 523-523, 527-527, 721-721, 729-729

src/FakeSchemaGrammar.php (2)

96-102: Added support for Laravel 12's table listing functionality

Implemented the compileTableListing method to ensure compatibility with Laravel 12's schema grammar requirements. The implementation correctly follows the pattern established by other methods in the class, returning a wrapper object with type 'getAllTables' and the SQL from the parent method.


31-32: Minor formatting improvements for consistency

Whitespace cleanup and formatting adjustments have been made to improve code readability and consistency.

Also applies to: 90-90, 108-108, 117-117, 160-160, 166-167

src/FakeConnection.php (2)

16-16: Improved object instantiation with explicit parentheses and proper dependency injection

Constructor calls now use explicit parentheses, and the connection instance is properly passed to the grammar constructor, which improves code clarity and follows proper dependency injection patterns.

Also applies to: 19-20, 50-50


41-45: Code formatting improvements for readability

Arguments to the FakeQueryBuilder constructor are now formatted on separate lines, and array key spacing is aligned, improving code readability.

Also applies to: 62-62

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@adrianmihaila adrianmihaila force-pushed the support-laravel12 branch 2 times, most recently from 1b67125 to 1d9fc83 Compare April 28, 2025 09:17
@adrianmihaila adrianmihaila marked this pull request as ready for review April 28, 2025 09:24
Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @adrianmihaila - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider separating the formatting adjustments (e.g., spacing) into a distinct pull request to simplify reviewing the functional changes for Laravel 12 support.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant