docker provider: default to runc, add docker_runsc overlay for gVisor#196
Open
gnguralnick wants to merge 1 commit into
Open
docker provider: default to runc, add docker_runsc overlay for gVisor#196gnguralnick wants to merge 1 commit into
gnguralnick wants to merge 1 commit into
Conversation
[providers.docker] no longer hardcodes docker_runtime="runsc", so it uses Docker's default runtime (runc), which is available everywhere -- notably macOS, where gVisor's runsc is not. This drops the need for the MNGR__PROVIDERS__DOCKER__DOCKER_RUNTIME=runc workaround on hosts without gVisor. Add a docker_runsc create-template overlay that opts a create into the gVisor runtime: `--template docker --template docker_runsc` reuses the entire docker template body and only switches the container runtime to runsc, so the runc/runsc choice is the single difference with no duplicated body to keep in sync. The minds desktop app stacks the overlay by default on Linux and omits it on macOS. Co-authored-by: Sculptor <sculptor@imbue.com>
5 tasks
Contributor
|
lgtm, will merge together |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The local
dockerprovider hardcoded the gVisor (runsc) runtime, which fails on macOS where gVisor is unavailable -- forcing theMNGR__PROVIDERS__DOCKER__DOCKER_RUNTIME=runcenv-var workaround beforejust minds-start.This makes the runtime a per-create choice:
[providers.docker]no longer setsdocker_runtime, so it uses Docker's default runtime (runc), which is available everywhere -- notably macOS.[create_templates.docker_runsc]overlay opts a create into gVisor:--template docker --template docker_runscreuses the entiredockertemplate body and only switches the container runtime torunsc. The runc/runsc choice is the single difference, with no duplicated template body to keep in sync.The template-contributed
providers.docker.docker_runtime=runscsetting reaches the provider at create time because mngr re-applies template--settingentries against the provider config after template resolution (imbue-ai/mngr#1914, verified present in both host-side and vendored mngr).Pairs with
imbue-ai/mngr#2237 -- the minds desktop app change that adds the per-platform "Container runtime" create-form field and selects this overlay by default on Linux (runc on macOS). The two must land together: this template is inert without the minds change, and the minds change references this template.
Test plan
.mngr/settings.tomlparses (tomllib):[providers.docker]has nodocker_runtime;[create_templates.docker_runsc]carriessetting__extend = ["providers.docker.docker_runtime=runsc"];[create_templates.docker]still setsprovider = "docker".--template docker_runscfor runsc and omits it for runc (minds: choose Docker container runtime (runc/runsc) per create instead of hardcoding gVisor mngr#2237).