Correct vendor/ docs: snapshots, not git subtree/submodule#200
Draft
weishi-imbue wants to merge 1 commit into
Draft
Correct vendor/ docs: snapshots, not git subtree/submodule#200weishi-imbue wants to merge 1 commit into
weishi-imbue wants to merge 1 commit into
Conversation
CLAUDE.md told agents to add external read-only deps as a git subtree, but vendor/mngr and vendor/tk are plain copied-in snapshots. State the real model (vendor/mngr re-synced from the mngr monorepo via just sync-vendor-mngr / the release flow; vendor/tk a manually-maintained fork, no upstream pull) and note the maintenance mechanism in README. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects the
vendor/guidance so agents stop treatingvendor/mngr/vendor/tkas git subtrees.CLAUDE.mdtold agents to add external read-only dependencies as agit subtreeundervendor/, but the team's actual model (per the vendor/mngr discussion) is thatvendor/mngrandvendor/tkare plain copied-in snapshots:vendor/mngrre-synced from the mngr monorepo (git archivefor releases,rsyncfor dev iteration),vendor/tka manually-maintained fork with no upstream pull. Neither is a subtree or submodule.Changes
CLAUDE.md-- replace the "add a git subtree" instruction with the real model; tell agents not to rungit subtree/git submoduleagainstvendor/.README.md-- note how each vendored dependency is maintained.The mngr monorepo's canonical sync doc (
apps/minds/docs/vendor-mngr-sync.md) is added in a companion PR (imbue-ai/mngr#2241).Generated with Claude Code