chore(dependencies): upgrade psalm to v6

[EmanFateen]

Q	A
Tickets	Fix #
License	MIT

Description:

While working on upgrading PHP to v8.4, I found that PSLAM v5 is a blocker, and it needs to be upgraded to v6.
I've opened this PR to upgrade PSLAM to v6.

Key changes:

• Upgrade PSLAM version to v6
• set pslam-baseline xml file.

[imdhemy]

@EmanFateen
Linking the PR to the issue will close it once this PR is merged. Either remove the issue from the description table or file a new issue for this PR.

[EmanFateen]

@imdhemy I removed the issue from the description table.

[imdhemy]

@EmanFateen
It's a good idea to separate Psalm into a different PR. I checked the Psalm errors and they fall into two groups:

1. Unused code

Psalm 6 changed the default configuration to detect unused code.

[BC] Property Config::$find_unused_code changed default value from false to true.

We can mark some parts as public API, as mentioned in the Psalm docs
(class, method).

But we still need to handle PossiblyUnusedProperty, because it seems to be a real issue.

2. Laravel code

This includes the config() helper and the console commands. We are already using the Psalm Laravel Plugin, but it is not upgraded yet.

https://github.com/EmanFateen/laravel-in-app-purchases/blob/fea74577326eef7c760c5b56eb16996f6854696c/composer.json#L30

The plugin can't be upgraded because it conflicts with the version required by orchestra/testbench, and we need to update that first.

I think we should upgrade orchestra/testbench and bump the minimum laravel/framework version, so we can still get the full advantage of Psalm.

What do you think?

[imdhemy]

• Upgrade orchestra/testbench.
• Upgrade psalm/plugin-laravel.
• Address Psalm issues.

[imdhemy]

I think we should upgrade orchestra/testbench and bump the minimum laravel/framework version, so we can still get the full advantage of Psalm.

@EmanFateen I addressed this in this PR #490

Let's upgrade the Psalm laravel plugin as well, and check how many issues we get.

[EmanFateen]

@imdhemy Thank you! I'm on it.
I'll Upgrade psalm/plugin-laravel. then revisit your comment about the Psalm issues.

[imdhemy]

@EmanFateen Thanks a million!