Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YVR Touch-v2 controller models and profiles #270

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

xkiti
Copy link

@xkiti xkiti commented Dec 30, 2024

No description provided.

@toji
Copy link
Member

toji commented Dec 30, 2024

The meshes look good, but some of the animation bindings aren't set up correctly.

On the left controller, everything animates as expected except for the trigger. The viewer gives the error:

Could not find xr_standard_trigger_pressed_min in the model

On the right controller several other bindings are missing, causing the trigger, grip/squeeze button, and thumbstick to not animate correctly (the A and B buttons work). It shows the following errors:

Could not find xr_standard_trigger_pressed_min in the model
Could not find xr_standard_squeeze_pressed_min in the model
Could not find xr_standard_thumbstick_pressed_min in the model
Could not find xr_standard_thumbstick_xaxis_pressed_min in the model
Could not find xr_standard_thumbstick_yaxis_pressed_min in the model

If you can fix these issues I'll be happy to merge the models! You can check out this guide for some help on how to set up the meshes.

Thank you for the contribution!

@xkiti
Copy link
Author

xkiti commented Jan 2, 2025

@toji Thank you for your reminder. I have modified the model file and it can now be correctly rendered on the web page as required by this guide

@toji
Copy link
Member

toji commented Jan 2, 2025

Everything looks good now, thank you for the quick update!

@toji toji merged commit 31de5c1 into immersive-web:main Jan 2, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants