Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Yvr touch v2 Controller Model #272

Closed
wants to merge 3 commits into from

Conversation

xkiti
Copy link

@xkiti xkiti commented Mar 12, 2025

I found that in this webxr application, the controller model does not fit the actual controller. like this:
image

So,I modified the initial rotation of the controller model.like this:
image

@toji
Copy link
Member

toji commented Mar 12, 2025

Thank you for testing the models and verifying the orientation! I appreciate the fix.

The PR seems like it needs a couple of adjustments before we can merge it, though:

  • It adds the .glb meshes to packages/registry/profiles/yvr/ when they should actually be updates to the ones already in packages/assets/profiles/yvr-touch-v2/
  • This PR shows you adding packages/assets/profiles/yvr-touch-v2/profile.json and packages/registry/profiles/yvr/yvr-touch-v2.json as new files, but those already exist in the repository and appear to be identical to the ones in this PR, so I'm not sure why it's saying they need to be added? Perhaps try rebasing against immersive-web:main?

If we can get those issues sorted out, though, I'm happy to merge the fix! Thanks again!

@xkiti xkiti closed this Mar 13, 2025
@xkiti xkiti deleted the yvr-touch-v2-fix branch March 13, 2025 03:49
@xkiti
Copy link
Author

xkiti commented Mar 13, 2025

I made a small mistake, and now I am resubmitting a PR #273 to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants