feat: original-sized previews for non-web-friendly images #29805
eligaotest.yml
on: pull_request
pre-job
7s
ShellCheck
6s
OpenAPI Clients
1m 12s
TypeORM Checks
1m 21s
Test & Lint Server
2m 19s
Unit Test CLI
25s
Unit Test CLI (Windows)
59s
Test & Lint Web
4m 50s
End-to-End Lint
31s
Medium Tests (Server)
2m 7s
End-to-End Tests (Server & CLI)
3m 34s
End-to-End Tests (Web)
2m 56s
Unit Test Mobile
1m 27s
Unit Test ML
0s
Annotations
4 errors and 9 warnings
|
TypeORM Checks
Process completed with exit code 1.
|
|
src/services/media.service.spec.ts > MediaService > handleGenerateThumbnails > should generate full-size preview directly from RAW images when extractEmbedded is false:
server/src/services/media.service.spec.ts#L755
AssertionError: expected "spy" to be called with arguments: [ …(3) ]
Received:
1st spy call:
[
{
"data": [
105,
109,
97,
103,
101,
32,
100,
97,
116,
97,
],
"type": "Buffer",
},
{
"colorspace": "p3",
- "format": "jpeg",
+ "format": "webp",
"processInvalidImages": false,
"quality": 80,
"raw": {
"channels": 3,
"height": 100,
"width": 100,
},
+ "size": 250,
},
- "upload/thumbs/user-id/as/se/asset-id-fullsize.jpeg",
+ "upload/thumbs/user-id/as/se/asset-id-thumbnail.webp",
]
2nd spy call:
[
{
"data": [
105,
109,
97,
103,
101,
32,
100,
97,
116,
97,
],
"type": "Buffer",
},
{
"colorspace": "p3",
"format": "jpeg",
"processInvalidImages": false,
"quality": 80,
"raw": {
"channels": 3,
"height": 100,
"width": 100,
},
+ "size": 1440,
},
- "upload/thumbs/user-id/as/se/asset-id-fullsize.jpeg",
+ "upload/thumbs/user-id/as/se/asset-id-preview.jpeg",
]
3rd spy call:
[
{
"data": [
105,
109,
97,
103,
101,
32,
100,
97,
116,
97,
],
"type": "Buffer",
},
{
"colorspace": "p3",
+ "enabled": true,
"format": "jpeg",
"processInvalidImages": false,
"quality": 80,
"raw": {
"channels": 3,
"height": 100,
"width": 100,
},
+ "size": undefined,
},
"upload/thumbs/user-id/as/se/asset-id-fullsize.jpeg",
]
Number of calls: 3
❯ src/services/media.service.spec.ts:755:43
|
|
src/services/media.service.spec.ts > MediaService > handleGenerateThumbnails > should generate full-size preview from non-web-friendly images:
server/src/services/media.service.spec.ts#L796
AssertionError: expected "spy" to be called with arguments: [ …(3) ]
Received:
1st spy call:
[
{
"data": [
105,
109,
97,
103,
101,
32,
100,
97,
116,
97,
],
"type": "Buffer",
},
{
"colorspace": "p3",
- "format": "jpeg",
+ "format": "webp",
"processInvalidImages": false,
"quality": 80,
"raw": {
"channels": 3,
"height": 100,
"width": 100,
},
+ "size": 250,
},
- "upload/thumbs/user-id/as/se/asset-id-fullsize.jpeg",
+ "upload/thumbs/user-id/as/se/asset-id-thumbnail.webp",
]
2nd spy call:
[
{
"data": [
105,
109,
97,
103,
101,
32,
100,
97,
116,
97,
],
"type": "Buffer",
},
{
"colorspace": "p3",
"format": "jpeg",
"processInvalidImages": false,
"quality": 80,
"raw": {
"channels": 3,
"height": 100,
"width": 100,
},
+ "size": 1440,
},
- "upload/thumbs/user-id/as/se/asset-id-fullsize.jpeg",
+ "upload/thumbs/user-id/as/se/asset-id-preview.jpeg",
]
3rd spy call:
[
{
"data": [
105,
109,
97,
103,
101,
32,
100,
97,
116,
97,
],
"type": "Buffer",
},
{
"colorspace": "p3",
+ "enabled": true,
"format": "jpeg",
"processInvalidImages": false,
"quality": 80,
"raw": {
"channels": 3,
"height": 100,
"width": 100,
},
+ "size": undefined,
},
"upload/thumbs/user-id/as/se/asset-id-fullsize.jpeg",
]
Number of calls: 3
❯ src/services/media.service.spec.ts:796:43
|
|
Test & Lint Server
Process completed with exit code 1.
|
|
ShellCheck
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
pre-job
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Unit Test CLI
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
End-to-End Lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
OpenAPI Clients
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
TypeORM Checks
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Unit Test Mobile
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Test & Lint Server
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Test & Lint Web
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|