-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend smart search, match exif-description too #14380
base: main
Are you sure you want to change the base?
feat: extend smart search, match exif-description too #14380
Conversation
Thanks for the PR! This has been a much-requested feature that I'm sure will bring a smile to many faces. There are some changes that need to be made first, though. You should create a trigram index and adjust this query to use it. They perform better, both for search time, finding results and in working with different languages. You can see The query will also need to be restructured. As written, it will do a brute force search on both all embeddings and all |
Thanks @mertalev will do this on weekend! |
Sounds good! I'd also like to mention that we're changing from TypeORM to Kysely very soon (#12857), so it may be the case that the change happens before this PR is merged. The DB migration won't be affected by this, but the |
I'll wait for it to be merged in that case, will be easier for me since I'm not that much familiar with the codebase. |
Any updates? |
@austinbaccus in queue to be worked on |
sorry guys but I won't be able to work on this PR anymore because of other things but I really hope someone else might be interested in working on this, because this is a really good feature that would benefit everyone (including me) |
Adding a feature to search images based on description.
I've extended /search/smart instead of creating /search/description, implemented due to personal need but wanted to share so everyone can benefit. Feedback welcome!
changelog:
When searching "beach vacation", results will first show images that have "beach vacation" in their description, and then visually similar images by embeddings (past behavior)