-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): Update documentation backup-and-restore #15679
base: main
Are you sure you want to change the base?
Conversation
- Fixed default database name. - Added default database user name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thank you for your PR.
- Regarding
DB_DATABASE_NAME
, this does not need to match the default immich database. Since we do a pg_dumpall, we want to connect to a default database that always exists - thepostgres
database is always there, so in that case the user will not have to edit the command. - I don't really know if it's valuable to include the defaults here as they may change in the future, and thus will require editing in more and more places, however if we do want to keep it I would put it in code ticks instead of single quotes
I guess it seems we should remove the |
Hi @mmomjian After looking at your comments, I think I agree with both of them.
Regarding your most recent comment about removing the But if it is valid, then please let me know and I can change the PR to reflect that. |
DB_DATABASE_NAME
should beimmich
, notpostgres
.DB_USERNAME
to the default information comment.