fix(server): ignore library scan permission errors #15936
Draft
+210
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etnoy
force-pushed
the
feat/ignore-library-permission-error
branch
from
224f4e5 to
43d66c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the bug where any permission denied error in a library scan cancels the entire scans and throws an error. Instead, we ignore permission errors and warn in the console.
There are several bugs reporting this, including #11177
How Has This Been Tested?
Added e2e test for the specific case. In order to make the docker be able to get permission errors, I added DAC_OVERRIDE as a capability drop.
In case of permission error, we now get a warning in the log:
Caveat
The upstream PR is not merged yet, therefore this PR is a draft for now