chore(mobile): search field in separate widget #16977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenlong-tanwen
approved these changes
Mar 19, 2025
|
Hi Yaros, I just tested the PR. The search in SearchPage and PeopleFilter components work but are broken on the Album page. Can you help checking that? |
|
I'll check it out and fix it soon! Thanks for testing and reporting :) |
|
@alextran1502 I've spent more time than I'd like to admit to spot this bug 😅 Please test again, it should work now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separated the search field into its separate widget, so the decoration properties wouldn't need to be copy-pasted in the future.
How Has This Been Tested?