feat: additional dedupe logic based on image format #22791
+98
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change updates the duplicate resolution logic to prefer certain filetypes over others - for example preferring HEIC over JPG or DNG over native camera raw formats. This change has a hard-coded priority list of different formats, which are used as the first duplicate selection mechanism.
This change makes it much easier to remove duplicates where you have the same file in multiple formats - with a preference towards newer or higher quality formats - even when the file size is smaller.
I didn't see an open issue on this, but there was a lot of discussion about this in #10665.
How Has This Been Tested?
Screenshots (if appropriate)
Checklist:
src/services/
uses repositories implementations for database calls, filesystem operations, etc.src/repositories/
is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/
)Please describe to which degree, if any, an LLM was used in creating this pull request.
I did use an LLM (Codex) to draft the first iteration of this code before refining and testing by hand.