analyze: discard rewrites on bounds checking code #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spernsteiner
force-pushed
the
analyze-ignore-bounds-checks
branch
from
0729135 to
b094dee
Compare
spernsteiner
force-pushed
the
analyze-ignore-bounds-checks-base
branch
from
de51ed9 to
a96f324
Compare
spernsteiner
changed the base branch from
analyze-ignore-bounds-checks-base
to
master
ahomescu
approved these changes
Dec 6, 2024
spernsteiner
force-pushed
the
analyze-ignore-bounds-checks
branch
from
b094dee to
6b266a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds logic for identifying the bounds-checking code that rustc automatically inserts around array and slice accesses and for discarding rewrites that would normally be generated for that code. Trying to rewrite this code is pointless because the code is derived automatically from other parts of the function, and it can trigger errors due to the rewriter not having a distinct place in the source code where it can apply the rewrites.
In the future, we could potentially extend this to skip rewrites on overflow assertions as well.