Staking contracts: ERC20 and Native IMX #912
drinkcoffeetest.yml
on: pull_request
Run Forge Tests
50s
Run Hardhat Tests
1m 14s
Run eslint
30s
Run solhint
29s
Run slither
2m 13s
Check README.md is contained in each contracts directory
5s
dependency-review
4s
Publish to NPM (dry run)
1m 21s
Annotations
10 errors and 10 warnings
|
|
|
|
|
|
|
Run solhint:
contracts/staking/StakeHolderBase.sol#L60
Replace address·_roleAdmin,·address·_upgradeAdmin,·address·_distributeAdmin with ⏎········address·_roleAdmin,⏎········address·_upgradeAdmin,⏎········address·_distributeAdmin⏎····
|
|
|
|
Run solhint:
contracts/staking/WIMX.sol#L40
Use Custom Errors instead of require statements
|
|
Run solhint:
contracts/staking/WIMX.sol#L85
Use Custom Errors instead of require statements
|
|
Run solhint:
contracts/staking/WIMX.sol#L88
Use Custom Errors instead of require statements
|
|
Run solhint
Process completed with exit code 1.
|
|
Run slither
Process completed with exit code 255.
|
|
Run solhint:
contracts/staking/StakeHolderBase.sol#L7
Variable "AccessControlUpgradeable" is unused
|
|
Run solhint:
contracts/staking/StakeHolderBase.sol#L8
Variable "IAccessControlUpgradeable" is unused
|
|
Run solhint:
contracts/staking/StakeHolderBase.sol#L11
Variable "StakeHolderBase" is unused
|
|
Run solhint:
contracts/staking/StakeHolderBase.sol#L109
Avoid making time-based decisions in your business logic
|
|
Run solhint:
contracts/staking/StakeHolderBase.sol#L192
Avoid making time-based decisions in your business logic
|
|
Run solhint:
contracts/staking/StakeHolderERC20.sol#L7
Variable "IStakeHolder" is unused
|
|
Run solhint:
contracts/staking/StakeHolderNative.sol#L5
Variable "IStakeHolder" is unused
|
|
Run solhint:
contracts/staking/StakeHolderWIMX.sol#L7
Variable "IStakeHolder" is unused
|
|
Run solhint:
contracts/staking/WIMX.sol#L17
Main key parameter in mapping balanceOf is not named
|
|
Run solhint:
contracts/staking/WIMX.sol#L17
Value parameter in mapping balanceOf is not named
|