Skip to content

Staking: Addressing internal audit feedback #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
drinkcoffee merged 1 commit into from
Mar 12, 2025
Merged

Staking: Addressing internal audit feedback #267

drinkcoffee merged 1 commit into from
Mar 12, 2025

Conversation

@drinkcoffee
Copy link
Contributor

@drinkcoffee drinkcoffee commented Mar 12, 2025

This PR addresses internal audit feedback for the staking contract. The changes are:

  • Add a DISTRIBUTE_ROLE to the staking contract.
  • Require the caller of distribute() to have the DISTRIBUTE_ROLE

rytimx
rytimx approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@rytimx rytimx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drinkcoffee drinkcoffee merged commit 688f056 into main Mar 12, 2025
8 checks passed
@drinkcoffee drinkcoffee deleted the peter-staking-3 branch May 15, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rytimx rytimx rytimx approved these changes

@w3njah w3njah w3njah approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drinkcoffee @rytimx @w3njah