[2.x] fix: eliminate N+1 queries when listing users - #54
Merged
Conversation
Batch-load groups, follower/following counts, and actor follow states in beforeSerialization so the user list endpoint issues a fixed number of queries regardless of how many users are returned. Adds request-scoped static caches to FollowState (seedCountCache, seedActorFollowStates) so serializer field getters never fall back to per-user queries once the batch has run. Migrates integration tests to PHPUnit 11 (attribute syntax, #[RunTestsInSeparateProcesses], updated XML schema), and ports the FollowUsersDiscussionFilterTest, FollowedUsersFilterGambitTest, UserAttributesTest, and ListUsersQueryCountTest from the 1.x branch.
imorland
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch-loads groups, follower/following counts, and actor follow states in a
beforeSerializationhook on theUserResourceindex endpoint, so the number of queries is constant regardless of how many users are in the list.Adds request-scoped static caches to
FollowState(seedCountCache,seedActorFollowStates) so serializer field getters never fall back to per-user queries once the batch has run.Also migrates integration tests to PHPUnit 11 (attribute syntax,
#[RunTestsInSeparateProcesses], updated XML schema), and portsFollowUsersDiscussionFilterTest,FollowedUsersFilterGambitTest,UserAttributesTest, andListUsersQueryCountTest(N+1 regression guard) from the 1.x branch.