-
Notifications
You must be signed in to change notification settings - Fork 13
Remove need for parentheses in many places #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…otations Co-authored-by: Portegies, Jim <[email protected]> Co-authored-by: Otte, P.J. (Pim)" <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great! It's really a large improvement.
One question: As a test and for the looks of it, it may be nice to also remove parentheses in library files, although this is not strictly necessary. What's your view on this?
Co-authored-by: jim-portegies <[email protected]>
I removed them incidentally, largely when I was touching stuff to add "as". I guess it would help to detect issues like the disjoint set ambiguity, so I'll probably remove more. |
The reason Some options:
My gut feeling is towards the second option, but I might be missing some other option to resolve the parsing ambiguity. @jim-portegies any thoughts? |
I'm leaning towards option 3. I don't mind 1 either. I am not the biggest fan of 2 because in principle I would like to communicate one way of doing things. |
Fair enough. From an engineering point of view, I'd like to then go with option 1 for this PR, we can then follow up with option 3 if we feel it's worth it. |
With some refactoring we might also be able to do Edit: After experimenting a bit, I don't think we can do this without disabling |
Fixes #115
TODO:
Replace Notation hacks by proper solution?Document hack, because ocaml API needed is in Coq 8.18Also makeLeaveChoose a.
work instead ofChoose (a).
Choose (a).
as-is.