Use checkpoints + hnsd dns api#32
Open
rithvikvibhu wants to merge 5 commits intoimperviousinc:mainfrom
Open
Conversation
pinheadmz
reviewed
Feb 19, 2023
internal/resolvers/proc/hns.go
Outdated
| func NewHNSProc(procPath string, rootAddr, recursiveAddr string) (*HNSProc, error) { | ||
| args := []string{"--ns-host", rootAddr, "--rs-host", recursiveAddr, "--pool-size", "4"} | ||
| func NewHNSProc(procPath string, rootAddr, recursiveAddr string, configPath string) (*HNSProc, error) { | ||
| args := []string{"--ns-host", rootAddr, "--rs-host", recursiveAddr, "--pool-size", "4", "-x", configPath} |
Collaborator
There was a problem hiding this comment.
Mine as well add -t as well to start from the hard coded checkpoint at height 136,000 ;-)
Collaborator
Author
There was a problem hiding this comment.
I misread this line from the PR and thought that -t would be ignored:
prefixwill overridecheckpointif both are used.
Turns out it does help starting from 136k if there's no written file. Added -t, thanks
|
Impressive! 5 seconds vs 2 minutes 35 seconds for me at the current height (<181k). Could this be merged and released with new binaries? For anyone who wants to try – I simply followed https://github.com/imperviousinc/fingertip#macos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hnsd: use checkpoints
Uses the
-x <prefix-dir>option of hnsd to store checkpoints on disk. See handshake-org/hnsd#99 for more info.The file is stored in Fingertip's config directory (along with dnssec cert, etc.)
hnsd: use dns api to get sync status
Instead of assuming that hnsd synced after 20 seconds, now the height and progress is fetched from hnsd every second. The tray menu and web page is updated to show the sync % like:
See handshake-org/hnsd#102 for more info.
I'm new to Go so may have missed best practices / easier ways to do things, so feel free to leave any number of comments to change or add your own commits :)