Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first: Allow reexports before imports #1522

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

first: Allow reexports before imports #1522

wants to merge 1 commit into from

Conversation

Andarist
Copy link

@Andarist Andarist commented Oct 29, 2019 •
edited
Loading

Reexports are also kinda imports and they don't even create local bindings so I believe this should be allowed.

fixes #801

@Andarist Andarist mentioned this pull request Oct 29, 2019
Open
@coveralls
Copy link

coveralls commented Oct 29, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 96.361% when pulling 9ab1145 on Andarist:first/allow-reexports into 112a0bf on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.286% when pulling 9ab1145 on Andarist:first/allow-reexports into 112a0bf on benmosher:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.286% when pulling 9ab1145 on Andarist:first/allow-reexports into 112a0bf on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.286% when pulling 9ab1145 on Andarist:first/allow-reexports into 112a0bf on benmosher:master.

ljharb
ljharb requested changes Dec 5, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only change via an option, not by default.

@ljharb ljharb marked this pull request as draft May 14, 2021 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
import/export ordering semver-minor
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import/first and reexports
3 participants
@Andarist @coveralls @ljharb