Match against "pattern*" as RegExp #2086
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: #1281 (comment)
We want to allow people to use a wildcard string in their core-modules settings.
This will convert "pattern*" into
RegExp('^pattern.*$')
while also still enforcing a direct match on core-module strings that do not have the wildcard.Per the issue thread, the allowable scenario was that the string ends in a wildcard, and nothing else.