Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] order: codify invariants from docs into config schema #3152

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Xunnamius
Copy link
Contributor

@Xunnamius Xunnamius commented Jan 26, 2025

Updating schema wrt #3127 (comment)

EDIT: depends on #3129 for its added tests

@ljharb
Copy link
Member

ljharb commented Jan 26, 2025

This PR seems to have too much stuff in it - but either way, if a rule or option is already released, its schema can’t be tightened further.

@Xunnamius
Copy link
Contributor Author

Xunnamius commented Jan 27, 2025

@ljharb It seems like it has a lot because it's on top of the consolidateIslands PR (rather than main so the schema changes can run against the latest tests), but the two new commits are tiny and only touch the schema and two tests. I can pull the lines around dependencies/consolidateIslands one commit up into the consolidateIslands PR if desired :)

EDIT: I can also rebase onto main and decouple from the other PRs, but not hitting all the new tests plus no direct tests of the schema makes me a bit nervous.

As for the tightening of existing options, I assume you're talking about lines 865 and 866 for pathGroupsExcludedImportTypes? I can revert those. I did add a comment to the groups schema warning that additional validation happens elsewhere, and added two newlines to the named schema for consistency, but those changes should be just cosmetic.

@ljharb
Copy link
Member

ljharb commented Jan 27, 2025

In that case, I'll wait to review this since it needs to wait on #3129

@ljharb ljharb marked this pull request as draft January 27, 2025 05:49
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes are non-breaking iff they exclude things that the rule already checks.

… which would also imply there's some code that can be removed, since the checks are not guaranteed to be done by eslint?

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.63%. Comparing base (4f145a2) to head (a73a2f2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3152      +/-   ##
==========================================
+ Coverage   95.17%   95.63%   +0.45%     
==========================================
  Files          83       83              
  Lines        3688     3687       -1     
  Branches     1331     1330       -1     
==========================================
+ Hits         3510     3526      +16     
+ Misses        178      161      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Xunnamius Xunnamius marked this pull request as ready for review February 17, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants