Skip to content

Fix: add accessibility updates to amount field #7692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 10, 2025

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Jan 24, 2025

Resolves:
Accessibility Audit: Give-033 & - Give-044
GIVE-2436

https://lw.slack.com/archives/C0355E6LBMZ/p1736794600442929

Description

This PR includes a couple updates for the amount field template.

  • An aria-label attribute for the field, as it lacks a corresponding <label>.
  • An aria-describedBy attribute for the field to match the field error when present.

Affects

  • Custom Amount field on Donation Forms.

Visuals

Screen.Recording.2025-01-27.at.10.06.34.AM.mov

Testing Instructions

ZIP: https://github.com/impress-org/givewp/actions/runs/15476347325

  • View a form.
  • Check the console and verify that the custom amount field is properly labeled with an aria-label attribute.
  • Set a minimum amount on the donation form.
  • Process a donation with an amount less than the minimum.
  • Verify that when an error occurs the amount field is focused and properly described by the error id.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review January 24, 2025 07:34
@JoshuaHungDinh JoshuaHungDinh changed the title Fix: add aria-label to custom amount field Fix: add accessibility updates to amount field Jan 27, 2025
@JoshuaHungDinh JoshuaHungDinh self-assigned this May 13, 2025
@JoshuaHungDinh JoshuaHungDinh removed the request for review from jonwaldstein May 19, 2025 18:37
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests.

@jonwaldstein jonwaldstein merged commit 242efdc into develop Jun 10, 2025
24 checks passed
@jonwaldstein jonwaldstein deleted the fix/custom-amount-audit-give-033 branch June 10, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants