-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add editable Campaign dropdown to Donation Details screen #7859
base: develop
Are you sure you want to change the base?
Feature: Add editable Campaign dropdown to Donation Details screen #7859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pauloiankoski you're a beast!! just left a couple comments, let me know your thoughts 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pauloiankoski nice job man!
@pauloiankoski some last minute feedback on this. Can we limit the donation form dropdown list by the selected Campaign? |
…gn in Donation Details screen
@jonwaldstein Implemented the filter on 47c5e99. Here’s my thought: since we’ve always been loading all forms from the beginning, why not keep doing it that way and handle everything with JavaScript, avoiding extra API requests? What I did was manually rebuild the Campaigns query to only include the necessary data for the dropdown (instead of loading the full model with all fields), but now including all related |
Latest update: flash forms dropdown on changing the selected campaign. See |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pauloiankoski nice job! ready for QA 🌈
Resolves GIVE-2367
Description
This pull request adds a Campaign dropdown to the Donation Details screen in the admin. It displays the campaign currently assigned to the donation and also allows admins to reassign the donation to a different campaign.
Additionally, this PR updates the action triggered when the Donation object is updated, ensuring that the
campaign_id
property is also updated in the revenue table.Affects
Donation Details screen
Visuals
CleanShot.2025-04-04.at.20.50.28.mp4
Edit: Added filter to Donation Forms dropdown based on the selected Campaign
Testing Instructions
Pre-review Checklist
@unreleased
tags included in DocBlocks